Skip to content

module: add specific error for dir import #33220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aduh95 wants to merge 7 commits into from
Closed

module: add specific error for dir import #33220

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
11cb078
module: add specific error for dir import
aduh95 May 3, 2020
cb7fe74
primodials
aduh95 May 4, 2020
30cd02e
fixup: primordials
aduh95 May 4, 2020
e3da38d
fixup
aduh95 May 5, 2020
1471091
fixup: nit
aduh95 May 5, 2020
112c552
fixup: Windows tests
aduh95 May 14, 2020
ed3dfc5
esm: improve commonjs hint on module not found
aduh95 May 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
esm: improve commonjs hint on module not found 
Adds hint when module specifier is a file URL.

Refs: #31906
  • Loading branch information
@aduh95
aduh95 authored May 14, 2020
commit ed3dfc5ee925c94dd832da3aa56479528ea4db3d
3 changes: 3 additions & 0 deletions lib/internal/modules/esm/resolve.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -758,6 +758,9 @@ function defaultResolve(specifier, context = {}, defaultResolveUnused) {
// resolved CommonJS module
if (error.code === 'ERR_MODULE_NOT_FOUND' ||
error.code === 'ERR_UNSUPPORTED_DIR_IMPORT') {
if (StringPrototypeStartsWith(specifier, 'file://')) {
specifier = fileURLToPath(specifier);
}
const found = resolveAsCommonJS(specifier, parentURL);
if (found) {
// Modify the stack and message string to include the hint
Expand Down