Skip to content

[v13.x backport] stream: pipeline should only destroy un-finished streams. #32980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ronag wants to merge 2 commits into from
Closed

[v13.x backport] stream: pipeline should only destroy un-finished streams. #32980

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e7f255
stream: pipeline should only destroy un-finished streams
ronag Apr 21, 2020
3f5f8cc
fixup
ronag Apr 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup
  • Loading branch information
@ronag
ronag committed Apr 23, 2020
commit 3f5f8cca9015f1eef65cbbd6ccc30c2928644e09
2 changes: 1 addition & 1 deletion test/parallel/test-stream-pipeline.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -966,7 +966,7 @@ const net = require('net');
dst.readable = false;
pipeline(src, dst, common.mustCall((err) => {
assert(!err);
assert.strictEqual(dst.destroyed, true);
assert.strictEqual(dst.destroyed, false);
}));
src.end();
}
Expand Down