Skip to content

test: refactor test-https-host-headers #32805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
himself65 wants to merge 1 commit into from
Closed

test: refactor test-https-host-headers #32805

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: refactor test-https-host-headers 
Use `common.mustCall` and `util.debuglog`. Remove unnecessary functions
  • Loading branch information
@himself65
himself65 committed Apr 13, 2020
commit 80acf588ca52bd9940318c2cfdbf5bf54ac085fb
205 changes: 96 additions & 109 deletions test/parallel/test-https-host-headers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,15 @@ if (!common.hasCrypto)

const assert = require('assert');
const https = require('https');
const debug = require('util').debuglog('test');

const options = {
key: fixtures.readKey('agent1-key.pem'),
cert: fixtures.readKey('agent1-cert.pem')
};
const httpsServer = https.createServer(options, reqHandler);
let counter = 0;

function reqHandler(req, res) {
console.log(`Got request: ${req.headers.host} ${req.url}`);
const httpsServer = https.createServer({
key: fixtures.readKey('agent1-key.pem'),
cert: fixtures.readKey('agent1-cert.pem'),
}, common.mustCall(function(req, res) {
debug(`Got request: ${req.headers.host} ${req.url}`);
if (req.url.startsWith('/setHostFalse')) {
assert.strictEqual(req.headers.host, undefined);
} else {
Expand All @@ -25,106 +25,93 @@ function reqHandler(req, res) {
}
res.writeHead(200, {});
res.end('ok');
}

function thrower(er) {
throw er;
}

testHttps();

function testHttps() {

let counter = 0;

function cb(res) {
counter--;
console.log(`back from https request. counter = ${counter}`);
if (counter === 0) {
httpsServer.close();
console.log('ok');
}
res.resume();
}, 9)).listen(0, common.mustCall(function(err) {
debug(`test https server listening on port ${this.address().port}`);
assert.ifError(err);
https.get({
method: 'GET',
path: `/${counter++}`,
host: 'localhost',
port: this.address().port,
rejectUnauthorized: false,
}, cb).on('error', common.mustNotCall());

https.request({
method: 'GET',
path: `/${counter++}`,
host: 'localhost',
port: this.address().port,
rejectUnauthorized: false,
}, cb).on('error', common.mustNotCall()).end();

https.request({
method: 'POST',
path: `/${counter++}`,
host: 'localhost',
port: this.address().port,
rejectUnauthorized: false,
}, cb).on('error', common.mustNotCall()).end();

https.request({
method: 'PUT',
path: `/${counter++}`,
host: 'localhost',
port: this.address().port,
rejectUnauthorized: false,
}, cb).on('error', common.mustNotCall()).end();

https.request({
method: 'DELETE',
path: `/${counter++}`,
host: 'localhost',
port: this.address().port,
rejectUnauthorized: false,
}, cb).on('error', common.mustNotCall()).end();

https.get({
method: 'GET',
path: `/setHostFalse${counter++}`,
host: 'localhost',
setHost: false,
port: this.address().port,
rejectUnauthorized: false,
}, cb).on('error', common.mustNotCall());

https.request({
method: 'GET',
path: `/${counter++}`,
host: 'localhost',
setHost: true,
// agent: false,
port: this.address().port,
rejectUnauthorized: false,
}, cb).on('error', common.mustNotCall()).end();

https.get({
method: 'GET',
path: `/setHostFalse${counter++}`,
host: 'localhost',
setHost: 0,
port: this.address().port,
rejectUnauthorized: false,
}, cb).on('error', common.mustNotCall());

https.get({
method: 'GET',
path: `/setHostFalse${counter++}`,
host: 'localhost',
setHost: null,
port: this.address().port,
rejectUnauthorized: false,
}, cb).on('error', common.mustNotCall());
}));

const cb = common.mustCall(function(res) {
counter--;
debug(`back from https request. counter = ${counter}`);
if (counter === 0) {
httpsServer.close();
debug('ok');
}

httpsServer.listen(0, function(er) {
console.log(`test https server listening on port ${this.address().port}`);
assert.ifError(er);
https.get({
method: 'GET',
path: `/${counter++}`,
host: 'localhost',
port: this.address().port,
rejectUnauthorized: false
}, cb).on('error', thrower);

https.request({
method: 'GET',
path: `/${counter++}`,
host: 'localhost',
port: this.address().port,
rejectUnauthorized: false
}, cb).on('error', thrower).end();

https.request({
method: 'POST',
path: `/${counter++}`,
host: 'localhost',
port: this.address().port,
rejectUnauthorized: false
}, cb).on('error', thrower).end();

https.request({
method: 'PUT',
path: `/${counter++}`,
host: 'localhost',
port: this.address().port,
rejectUnauthorized: false
}, cb).on('error', thrower).end();

https.request({
method: 'DELETE',
path: `/${counter++}`,
host: 'localhost',
port: this.address().port,
rejectUnauthorized: false
}, cb).on('error', thrower).end();

https.get({
method: 'GET',
path: `/setHostFalse${counter++}`,
host: 'localhost',
setHost: false,
port: this.address().port,
rejectUnauthorized: false
}, cb).on('error', thrower);

https.request({
method: 'GET',
path: `/${counter++}`,
host: 'localhost',
setHost: true,
// agent: false,
port: this.address().port,
rejectUnauthorized: false
}, cb).on('error', thrower).end();

https.get({
method: 'GET',
path: `/setHostFalse${counter++}`,
host: 'localhost',
setHost: 0,
port: this.address().port,
rejectUnauthorized: false
}, cb).on('error', thrower);

https.get({
method: 'GET',
path: `/setHostFalse${counter++}`,
host: 'localhost',
setHost: null,
port: this.address().port,
rejectUnauthorized: false
}, cb).on('error', thrower);
});
}
res.resume();
}, 9);