Skip to content

doc: address various uses of "obvious" and "obviously" #32457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 3 commits into from
Closed

doc: address various uses of "obvious" and "obviously" #32457

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ab1efab
doc: trim wording in n-api.md text about exceptions
Trott Mar 24, 2020
5e350bc
doc: remove unnecessary "obvious(ly)" modifiers in esm.md
Trott Mar 24, 2020
76f399e
doc: remove extraneous sentence in events.md
Trott Mar 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
doc: trim wording in n-api.md text about exceptions
  • Loading branch information
@Trott
Trott committed Mar 24, 2020
commit ab1efabb7f13c28a7317fe0423e37bdac8df479f
5 changes: 2 additions & 3 deletions doc/api/n-api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -799,9 +799,8 @@ This API can be called even if there is a pending JavaScript exception.
### Exceptions

Any N-API function call may result in a pending JavaScript exception. This is
obviously the case for any function that may cause the execution of
JavaScript, but N-API specifies that an exception may be pending
on return from any of the API functions.
the case for any of the API functions, even those that may not cause the
execution of JavaScript.

If the `napi_status` returned by a function is `napi_ok` then no
exception is pending and no additional action is required. If the
Expand Down