Skip to content

fs: add fs.readv() #32356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SheikhSajid wants to merge 5 commits into from
Closed

fs: add fs.readv() #32356

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9048cae
fs: Add fs.readv()
SheikhSajid Mar 16, 2020
dc086c6
Fix readvSync
SheikhSajid Mar 19, 2020
0051182
Add tests for readvSync
SheikhSajid Mar 19, 2020
88f3d38
Fix typo
SheikhSajid Mar 19, 2020
5e56b8a
Fix linting errors
SheikhSajid Mar 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix readvSync
  • Loading branch information
@SheikhSajid
SheikhSajid committed Mar 19, 2020
commit dc086c6bd77a146ea10e19bf76557a5621182795
2 changes: 1 addition & 1 deletion lib/fs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -592,7 +592,7 @@ function readvSync(fd, buffers, position) {
if (typeof position !== 'number')
position = null;

const result = binding.writeBuffers(fd, buffers, position, undefined, ctx);
const result = binding.readBuffers(fd, buffers, position, undefined, ctx);
handleErrorFromBinding(ctx);
return result;
}
Expand Down