Skip to content

test: uv_tty_init returns EBADF on IBM i #32338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dmabupt wants to merge 1 commit into from
Closed

test: uv_tty_init returns EBADF on IBM i #32338

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: uv_tty_init returns EBADF on IBM i 
When TTY initialization failed, uv_tty_init returned EBADF on IBM i
PASE, rather than EINVAL
  • Loading branch information
@dmabupt
dmabupt committed Mar 18, 2020
commit 3059108fe413e1a1160e868121bec50a6caf259a
9 changes: 5 additions & 4 deletions test/parallel/test-ttywrap-invalid-fd.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,14 @@ assert.throws(

{
const info = {
code: common.isWindows ? 'EBADF' : 'EINVAL',
message: common.isWindows ? 'bad file descriptor' : 'invalid argument',
errno: common.isWindows ? UV_EBADF : UV_EINVAL,
code: common.isWindows || common.isIBMi ? 'EBADF' : 'EINVAL',
message: common.isWindows ||
common.isIBMi ? 'bad file descriptor' : 'invalid argument',
errno: common.isWindows || common.isIBMi ? UV_EBADF : UV_EINVAL,
syscall: 'uv_tty_init'
};

const suffix = common.isWindows ?
const suffix = common.isWindows || common.isIBMi ?
'EBADF (bad file descriptor)' : 'EINVAL (invalid argument)';
const message = `TTY initialization failed: uv_tty_init returned ${suffix}`;

Expand Down