Skip to content

build: add commit message linting to workflow #32336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
richardlau wants to merge 1 commit into from
Closed

build: add commit message linting to workflow #32336

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
build: Add commit message linting to workflow 
Run linting on the commit message of the first commit in a pull
request as part of our GitHub actions CI workflow. If linting fails
the pull request will be labelled as requiring a fix to the commit
message. The check itself will always pass so as to not concern
first time contributors.

Signed-off-by: Richard Lau <riclau@uk.ibm.com>
  • Loading branch information
@richardlau
richardlau committed Mar 18, 2020
commit 22838f6fbdd35fde3ed4d57d979395c57f2968c2
17 changes: 17 additions & 0 deletions .github/workflows/CI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,23 @@ jobs:
node-version: 10.x
- name: Lint addon docs
run: NODE=$(which node) make lint-addon-docs
lint-commit-message:
runs-on: ubuntu-latest
if: github.event_name == 'pull_request'
steps:
- uses: actions/checkout@v2
with:
fetch-depth: 0
- name: Lints message of the first commit in this pull request
continue-on-error: true
run: bash -x tools/lint-pr-commit-message.sh ${{ github.event.number }} || echo ::set-env name=needs_fixup::true
- name: Label on commit message lint failure
if: env.needs_fixup == 'true'
uses: actions/github@v1.0.0
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
args: label "needs commit message fix"
lint-cpp:
runs-on: ubuntu-latest
steps:
Expand Down