Skip to content

http: don't emit 'readable' after 'close' #32277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ronag wants to merge 3 commits into from
Closed

http: don't emit 'readable' after 'close' #32277

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8cd9b3d
http: don't emit 'readable' after 'close'
ronag Mar 15, 2020
c48885a
fixup
ronag Mar 15, 2020
0d9b733
fixup: test
ronag Mar 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
http: don't emit 'readable' after 'close'
  • Loading branch information
@ronag
ronag committed Mar 15, 2020
commit 8cd9b3d6ac17ad81295d8cb7d2eeccd47140d590
2 changes: 2 additions & 0 deletions lib/_http_server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -687,6 +687,8 @@ function resOnFinish(req, res, socket, state, server) {
req._dump();

res.detachSocket(socket);
// TODO(ronag): streamify IncomingMessage.destroy()
req._readableState.destroyed = true;
req.emit('close');
process.nextTick(emitCloseNT, res);

Expand Down
7 changes: 7 additions & 0 deletions test/parallel/test-async-hooks-http-parser-destroy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,13 @@ async_hooks.createHook({
}).enable();

const server = http.createServer((req, res) => {
let closed = false;
req.on('close', () => {
Comment thread
ronag marked this conversation as resolved.
Outdated
closed = true;
});
req.on('readable', () => {
Comment thread
ronag marked this conversation as resolved.
Outdated
assert.strictEqual(closed, false);
});
res.end('Hello');
});

Expand Down