Skip to content

esm: doc & validate source values for formats #32202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bmeck wants to merge 6 commits into from
Closed

esm: doc & validate source values for formats #32202

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
614ec8e
esm: doc & validate source values for formats
bfarias-godaddy Mar 11, 2020
d2c1e51
Update doc/api/esm.md
bmeck May 18, 2020
ecb72bc
Update doc/api/esm.md
bmeck May 18, 2020
d7d8024
Update doc/api/esm.md
bmeck May 19, 2020
759e4f2
Update doc/api/esm.md
bmeck May 19, 2020
525554d
Update doc/api/esm.md
bmeck May 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update doc/api/esm.md 
Co-authored-by: Derek Lewis <DerekNonGeneric@inf.is>
  • Loading branch information
@bmeck
bmeck and Derek Lewis authored May 18, 2020
commit d2c1e519334c3a8ae829453521e4009557b5e962
4 changes: 2 additions & 2 deletions doc/api/esm.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1209,8 +1209,8 @@ of the following:
| `'module'` | Load a standard JavaScript module (ES module) | array buffer, string, or typed array |
| `'wasm'` | Load a WebAssembly module | array buffer, or typed array |

For text based formats like `'json'` or `'module'` if the source value is not a
string it will be converted to a string using [`util.TextDecoder`][].
Note: If the source value of a text-based format (i.e., `'json'`, `'module'`) is not a
string, it will be converted to a string using [`util.TextDecoder`][].
Comment thread
bmeck marked this conversation as resolved.
Resolved

Note: `Buffer` is a form of typed array.

Expand Down