Skip to content

perf,src: add HistogramBase and internal/histogram.js #31988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jasnell wants to merge 3 commits into from
Closed

perf,src: add HistogramBase and internal/histogram.js #31988

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ed89699
perf,src: add HistogramBase and internal/histogram.js
jasnell Feb 27, 2020
3785cc2
fixup! perf,src: add HistogramBase and internal/histogram.js
jasnell Feb 29, 2020
8606c61
fixup! fixup! perf,src: add HistogramBase and internal/histogram.js
jasnell Feb 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! fixup! perf,src: add HistogramBase and internal/histogram.js
  • Loading branch information
@jasnell
jasnell committed Feb 29, 2020
commit 8606c61895fce687d667a1d7c967a6d1cc140ab4
2 changes: 1 addition & 1 deletion src/histogram.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ void HistogramBase::GetPercentiles(
ASSIGN_OR_RETURN_UNWRAP(&histogram, args.Holder());
CHECK(args[0]->IsMap());
Local<Map> map = args[0].As<Map>();
histogram->Percentiles([map,env](double key, double value) {
histogram->Percentiles([map, env](double key, double value) {
map->Set(
env->context(),
Number::New(env->isolate(), key),
Expand Down