Skip to content

src: include large pages source unconditionally #31904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gabrielschulhof wants to merge 3 commits into from
Closed

src: include large pages source unconditionally #31904

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2d72f17
src: include large pages source unconditionally
Feb 21, 2020
cdb7f73
cerrno must be included unconditionally
Feb 21, 2020
4327245
make the opening of the node namespace unconditional
Feb 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
cerrno must be included unconditionally
  • Loading branch information
Gabriel Schulhof
Gabriel Schulhof committed Feb 21, 2020
commit cdb7f73e2519b4de627d9ebd88d8b9cd7a76a113
3 changes: 2 additions & 1 deletion src/large_pages/node_large_page.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@

#include "node_large_page.h"

#include <cerrno> // NOLINT(build/include)

// Besides returning ENOTSUP at runtime we do nothing if this define is missing.
#if defined(NODE_ENABLE_LARGE_CODE_PAGES) && NODE_ENABLE_LARGE_CODE_PAGES
#include "util.h"
Expand All @@ -38,7 +40,6 @@
#endif
#include <unistd.h> // readlink

#include <cerrno> // NOLINT(build/include)
#include <climits> // PATH_MAX
#include <clocale>
#include <csignal>
Expand Down