Skip to content

src: use hex not decimal in IsArrayIndex #31758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
codebytere wants to merge 1 commit into from
Closed

src: use hex not decimal in IsArrayIndex #31758

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
src: use hex not decimal in IsArrayIndex
  • Loading branch information
@codebytere
codebytere committed Feb 13, 2020
commit 6cb838e883bd0c6bf2c3578baee07e400bcac651
2 changes: 1 addition & 1 deletion src/module_wrap.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -951,7 +951,7 @@ bool IsArrayIndex(Environment* env, Local<Value> p) {
if (!n->ToInteger(context).ToLocal(&cmp_integer)) {
return false;
}
return n_dbl > 0 && n_dbl < (2 ^ 32) - 1;
return n_dbl > 0 && n_dbl < (1LL << 32) - 1;
}

Maybe<URL> ResolveExportsTarget(Environment* env,
Expand Down