Skip to content

feat: make fs.read params optional #31402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lholmquist wants to merge 17 commits into from
Closed

feat: make fs.read params optional #31402

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
95f03ef
feat: make fs.read params optional
lholmquist Jan 16, 2020
478d2f0
squash: doc updates
lholmquist Jan 22, 2020
10d3902
squash: adding in test
lholmquist Jan 22, 2020
dfdd3b4
squash: better use of destructoring
lholmquist Jan 22, 2020
cf320a0
squash: refactor.
lholmquist Feb 11, 2020
418b6fd
squash: Update doc/api/fs.md
lholmquist Feb 12, 2020
e3835c2
squash: Update doc/api/fs.md
lholmquist Feb 12, 2020
128aeab
squash: reverting some doc updates
lholmquist Feb 12, 2020
2c5d3e7
squash: Update doc/api/fs.md
lholmquist Feb 13, 2020
6433727
squash: Update doc/api/fs.md
lholmquist Feb 13, 2020
3923975
squash: add test for promise based
lholmquist Feb 13, 2020
f6f01b6
squash: add defaults to filehandler.read docs
lholmquist Feb 14, 2020
55a2356
squash: add the use case for an optional options object
lholmquist Feb 26, 2020
f86bdc1
squash: add test for optional options option
lholmquist Feb 26, 2020
a4c3763
squash: a little more doc update
lholmquist Feb 26, 2020
e321b88
squash: doc linting
lholmquist Feb 26, 2020
cb8c0ef
squash: combine tests and add another test that passes options
lholmquist Mar 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
squash: adding in test
  • Loading branch information
@lholmquist
lholmquist committed Jan 22, 2020
commit 10d3902db2ef8d089e25576bc794abaa8ee767a1
18 changes: 18 additions & 0 deletions test/parallel/test-fs-read-optional-params.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
'use strict';

const common = require('../common');
const fixtures = require('../common/fixtures');
const fs = require('fs');
const assert = require('assert');
const filepath = fixtures.path('x.txt');
const fd = fs.openSync(filepath, 'r');

const expected = Buffer.from('xyz\n');
const defaultBufferAsync = Buffer.alloc(16384);

// Optional buffer, offset, length, position
// fs.read(fd, callback);
fs.read(fd, common.mustCall((err, bytesRead, buffer) => {
assert.strictEqual(bytesRead, expected.length);
assert.deepStrictEqual(defaultBufferAsync.length, buffer.length);
}));
Comment thread
ronag marked this conversation as resolved.