Skip to content

v10.18.1 proposal #31248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BethGriggs merged 16 commits into from
Jan 9, 2020
Merged

v10.18.1 proposal #31248

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
a80c591
build: fix configure script to work with Apple Clang 11
saagarjha Jun 5, 2019
4879b80
tools: fix v8 testing with devtoolset on ppcle
sam-github Jun 27, 2019
4ae8d20
tools: move python code out of jenkins shell
sam-github Jun 27, 2019
81c3100
lib: fix comment nits in bootstrap\loaders.js
vsemozhetbyt Nov 23, 2018
0f3ae77
tools: update tzdata to 2019c
MylesBorins Nov 13, 2019
3e0709c
deps: V8: backport fb63e5cf55e9
targos Nov 12, 2019
88e8b7c
n-api: correct bug in napi_get_last_error
Nov 18, 2019
68b2b5c
build,win: propagate error codes in vcbuild
joaocgreis Nov 30, 2019
7e941eb
test: do not fail SLOW tests if they are not slow
hashseed Feb 1, 2019
20f64a9
http2: use the latest settings
ZYSzys Oct 1, 2019
894aaa2
stream: extract Readable.from in its own file
mcollina Oct 26, 2019
8f3b8ca
http2: fix session memory accounting after pausing
Nov 27, 2019
25b8fbd
doc: allow <code> in header elements
Trott Dec 23, 2019
a1b095d
doc,dns: use code markup/markdown in headers
Trott Dec 23, 2019
77e0318
stream: increase MAX_HWM
ronag Oct 20, 2019
8d5e286
2020-01-09, Version 10.18.1 'Dubnium' (LTS)
BethGriggs Jan 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
deps: V8: backport fb63e5cf55e9 
Original commit message:

    [Intl] Fix output of hour:'2-digit', hour12: true

    Bug: chromium:527926
    Change-Id: I783ba59c6e4b117163e058032fb04283e1f43c46
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1529260
    Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
    Commit-Queue: Frank Tang <ftang@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#60379}

Refs: v8/v8@fb63e5c

Fixes: #30369

Backport-PR-URL: #30372
  • Loading branch information
@targos @MylesBorins
targos authored and MylesBorins committed Dec 17, 2019
commit 3e0709cf5e7b6a44c9b84cb9144dd41ee54cb932
2 changes: 1 addition & 1 deletion common.gypi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.54',
'v8_embedder_string': '-node.55',

# Enable disassembler for `--print-code` v8 options
'v8_enable_disassembler': 1,
Expand Down
4 changes: 3 additions & 1 deletion deps/v8/src/objects/intl-objects.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,9 @@ icu::SimpleDateFormat* CreateICUDateFormat(Isolate* isolate,
status));
icu::UnicodeString pattern;
if (U_SUCCESS(status))
pattern = generator->getBestPattern(skeleton, status);
pattern = generator->getBestPattern(skeleton,
UDATPG_MATCH_HOUR_FIELD_LENGTH,
status);

date_format = new icu::SimpleDateFormat(pattern, icu_locale, status);
if (U_SUCCESS(status)) {
Expand Down
19 changes: 19 additions & 0 deletions deps/v8/test/intl/regress-527926.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
// Copyright 2019 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

let date = new Date(2015, 8, 1, 3, 0, 0);
var fmt = new Intl.DateTimeFormat('ru', {hour:'2-digit', minute: '2-digit'})
assertEquals("03:00", fmt.format(date));

fmt = new Intl.DateTimeFormat(
'en', {hour:'2-digit', minute: '2-digit', hour12: false});
assertEquals("03:00", fmt.format(date));

fmt = new Intl.DateTimeFormat(
'ru', {hour:'2-digit', minute: '2-digit', hour12: false});
assertEquals("03:00", fmt.format(date));

fmt = new Intl.DateTimeFormat(
'ru', {hour:'2-digit', minute: '2-digit', hour12: true});
assertEquals("03:00 AM", fmt.format(date));