Skip to content

benchmark: include writev & callback in benchmark #31066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ronag wants to merge 5 commits into from
Closed

benchmark: include writev & callback in benchmark #31066

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d1603cd
benchmark: include writev in benchmark
ronag Dec 23, 2019
4155712
fixup: test w/ callback
ronag Dec 23, 2019
704ac6a
fixup: nit
ronag Dec 23, 2019
a7770b7
fixup: lint
ronag Dec 23, 2019
7f60522
fixup
ronag Dec 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 25 additions & 9 deletions benchmark/streams/writable-manywrites.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,25 +5,41 @@ const Writable = require('stream').Writable;

const bench = common.createBenchmark(main, {
n: [2e6],
sync: ['yes', 'no']
sync: ['yes', 'no'],
writev: ['yes', 'no'],
callback: ['yes', 'no']
});

function main({ n, sync }) {
function nop() {}

function main({ n, sync, writev, callback }) {
const b = Buffer.allocUnsafe(1024);
const s = new Writable();
sync = sync === 'yes';
s._write = function(chunk, encoding, cb) {
if (sync)
cb();
else
process.nextTick(cb);
};

if (writev === 'yes') {
s._writev = function(chunks, cb) {
if (sync)
cb();
else
process.nextTick(cb);
};
} else {
s._write = function(chunk, encoding, cb) {
if (sync)
cb();
else
process.nextTick(cb);
};
}
Comment thread
ronag marked this conversation as resolved.
Resolved

const cb = callback === 'yes' ? nop : null;
Comment thread
ronag marked this conversation as resolved.
Resolved

bench.start();

let k = 0;
function run() {
while (k++ < n && s.write(b));
while (k++ < n && s.write(b, cb));
if (k >= n)
bench.end(n);
}
Expand Down