Skip to content

http2: make http2/compat.write more http/1 compliant #30964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ronag wants to merge 4 commits into from
Closed

http2: make http2/compat.write more http/1 compliant #30964

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e09aa04
http2: make HTTP2ServerResponse more streams compliant
ronag Dec 14, 2019
4684a1e
fixup: align with http1 instead of streams
ronag Dec 14, 2019
2f0d4b1
fixup: cleaner version
ronag Dec 14, 2019
9da63be
fixup: removed destroyed test
ronag Dec 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup: cleaner version
  • Loading branch information
@ronag
ronag committed Jan 1, 2020
commit 2f0d4b109250179fa74f01a5df6f8a525cf1c23b
22 changes: 12 additions & 10 deletions lib/internal/http2/compat.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -651,30 +651,32 @@ class Http2ServerResponse extends Stream {
}

write(chunk, encoding, cb) {
const state = this[kState];

if (typeof encoding === 'function') {
cb = encoding;
encoding = 'utf8';
}

if (this[kState].ending) {
const err = new ERR_STREAM_WRITE_AFTER_END();
if (typeof cb === 'function')
process.nextTick(cb, err);
this.destroy(err);
let err;
if (state.ending) {
err = new ERR_STREAM_WRITE_AFTER_END();
} else if (state.closed) {
err = new ERR_HTTP2_INVALID_STREAM();
} else if (state.destroyed) {
return false;
} else if (this[kState].closed) {
const err = new ERR_HTTP2_INVALID_STREAM();
}

if (err) {
if (typeof cb === 'function')
process.nextTick(cb, err);
this.destroy(err);
return false;
} else if (this[kState].destroyed) {
return false;
}

const stream = this[kStream];
if (!stream.headersSent)
this.writeHead(this[kState].statusCode);
this.writeHead(state.statusCode);
return stream.write(chunk, encoding, cb);
}

Expand Down