Skip to content

lib: replace ArrayBuffer.isView by primordial ArrayBuffer #30692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Kawacrepe wants to merge 1 commit into from
Closed

lib: replace ArrayBuffer.isView by primordial ArrayBuffer #30692

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
lib: replace ArrayBuffer.isView by primordial ArrayBuffer
  • Loading branch information
@Kawacrepe
Kawacrepe committed Nov 27, 2019
commit 0d1ae35c03427e873e1c84f4f3a209954e020a1b
3 changes: 2 additions & 1 deletion lib/string_decoder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
'use strict';

const {
ArrayBufferIsView,
ObjectDefineProperties,
} = primordials;

Expand Down Expand Up @@ -74,7 +75,7 @@ function StringDecoder(encoding) {
StringDecoder.prototype.write = function write(buf) {
if (typeof buf === 'string')
return buf;
if (!ArrayBuffer.isView(buf))
if (!ArrayBufferIsView(buf))
throw new ERR_INVALID_ARG_TYPE('buf',
['Buffer', 'TypedArray', 'DataView'],
buf);
Expand Down