Skip to content

fs: fix existsSync for invalid symlink at win32 #30556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pd4d10 wants to merge 2 commits into from
Closed

fs: fix existsSync for invalid symlink at win32 #30556

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
842dcf3
fs: fix existsSync for invalid symlink at win32
pd4d10 Nov 22, 2019
521f433
fixup
pd4d10 Nov 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup
  • Loading branch information
@pd4d10
pd4d10 authored Nov 22, 2019
commit 521f4331cacf54c1a6a69a1e866718ab4822f89c
6 changes: 3 additions & 3 deletions lib/fs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,9 +231,9 @@ function existsSync(path) {
const nPath = pathModule.toNamespacedPath(path);
binding.access(nPath, F_OK, undefined, ctx);

// If it is an invalid symlink, existsSync should return false
// binding.access checking is not enough for win32 (return true in this case)
// So we need to call binding.stat for double checking
// In case of an invalid symlink, `binding.access()` on win32
// will **not** return an error and is therefore not enough.
// Double check with `binding.stat()`.
if (isWindows && ctx.errno === undefined) {
binding.stat(nPath, false, undefined, ctx);
}
Expand Down