Skip to content

src,doc: add C++ internals documentation #30552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 13 commits into from
Closed

src,doc: add C++ internals documentation #30552

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
d3d23cd
src,doc: add C++ internals documentation
addaleax Nov 19, 2019
cbc4152
fixup! src,doc: add C++ internals documentation
addaleax Nov 20, 2019
09386ef
fixup! src,doc: add C++ internals documentation
addaleax Nov 20, 2019
4ef7a31
fixup! src,doc: add C++ internals documentation
addaleax Nov 20, 2019
130ef12
fixup! src,doc: add C++ internals documentation
addaleax Nov 20, 2019
2445c17
fixup! src,doc: add C++ internals documentation
addaleax Nov 20, 2019
e1ca24c
fixup! src,doc: add C++ internals documentation
addaleax Nov 20, 2019
309fab4
fixup! src,doc: add C++ internals documentation
addaleax Nov 20, 2019
f50f971
fixup! src,doc: add C++ internals documentation
addaleax Nov 20, 2019
9848ba5
fixup! fixup! src,doc: add C++ internals documentation
addaleax Nov 20, 2019
5a5f9e3
fixup! fixup! fixup! src,doc: add C++ internals documentation
addaleax Nov 20, 2019
7d32e28
fixup! src,doc: add C++ internals documentation
addaleax Nov 22, 2019
b49430d
fixup! src,doc: add C++ internals documentation
addaleax Nov 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! src,doc: add C++ internals documentation 
Co-Authored-By: Jiawen Geng <technicalcute@gmail.com>
  • Loading branch information
@addaleax @gengjiawen
addaleax and gengjiawen authored Nov 20, 2019
commit 09386ef6d0f414a574b56d827212e571aef01132
12 changes: 6 additions & 6 deletions src/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ function getFoo(obj) {

```c++
v8::Local<v8::Value> GetFoo(v8::Local<v8::Context> context,
v8::Local<Object> obj) {
v8::Local<v8::Object> obj) {
v8::Isolate* isolate = context->GetIsolate();
v8::EscapableHandleScope handle_scope(isolate);

Expand All @@ -112,7 +112,7 @@ v8::Local<v8::Value> GetFoo(v8::Local<v8::Context> context,
"foo",
v8::NewStringType::kNormal).ToLocalChecked();

v8::Local<Value> return_value;
v8::Local<v8::Value> return_value;
if (obj->Get(context, foo_string).ToLocal(&return_value)) {
return handle_scope.Escape(return_value);
} else {
Expand Down Expand Up @@ -421,12 +421,12 @@ v8::Maybe<double> SumNumbers(v8::Local<v8::Context> context,

double sum = 0;

for (int i = 0; i < array_of_integers->Length()) {
for (uint32_t i = 0; i < array_of_integers->Length(); i++) {
v8::Local<v8::Value> entry;
if (array_of_integers->Get(context, i).ToLocal(&entry)) {
// Oops, we might have hit a getter that throws an exception!
// It’s better to not continue return an empty (“nothing”) Maybe.
return v8::Nothing<uint32_t>();
return v8::Nothing<double>();
}

if (!entry->IsNumber()) {
Expand All @@ -442,7 +442,7 @@ v8::Maybe<double> SumNumbers(v8::Local<v8::Context> context,
sum += entry_as_number->Value();
}

return Just(sum);
return v8::Just(sum);
}

// Function that is exposed to JS:
Expand Down Expand Up @@ -636,7 +636,7 @@ Every `AsyncWrap` instance is associated with two numbers, the “async id”
and the “async trigger id”. The “async id” is generally unique per `AsyncWrap`
instance, and only changes when the object is re-used in some way.

See the [`async_hooks` module][] documentation for more inforation about how
See the [`async_hooks` module][] documentation for more information about how
this information is provided to async tracking tools.

<a id="makecallback"></a>
Expand Down