Skip to content

Consistency of method naming #30506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
meelash wants to merge 2 commits into from
Closed

Consistency of method naming #30506

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92e8376
Consistency of method naming
Nov 16, 2019
84c9855
Consistently name push method in transform section
Mar 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Consistency of method naming 
referred to as readable.push several other times in transform documentation and also documented under readable, so makes sense to just stick with readable.push
  • Loading branch information
Saleem
Saleem authored Nov 16, 2019
commit 92e83760d1b1bd54598a4f2fa58d0f4f0689f109
2 changes: 1 addition & 1 deletion doc/api/stream.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2534,7 +2534,7 @@ method to accept input and produce output. The `transform._transform()`
implementation handles the bytes being written, computes an output, then passes
that output off to the readable portion using the `readable.push()` method.

The `transform.push()` method may be called zero or more times to generate
The `readable.push()` method may be called zero or more times to generate
output from a single input chunk, depending on how much is to be output
as a result of the chunk.

Expand Down