Skip to content

src: cleanup unused headers #30328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alferpal wants to merge 8 commits into from
Closed

src: cleanup unused headers #30328

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
01d3211
src: cleanup unused headers
alferpal Nov 7, 2019
a33c48d
src: remove unnecessary v8 forward declarations
alferpal Nov 8, 2019
4200839
src: add missing namespace comment
alferpal Nov 10, 2019
f28b8c4
src: include env-inl in string_bytes
alferpal Nov 10, 2019
77d07ce
src: remove unnecessary forward declarations
alferpal Nov 12, 2019
240ba7d
src: include base_object in module_wrap.h
alferpal Nov 12, 2019
d7f2f40
src: fix build errors on macos
alferpal Nov 26, 2019
db5d6f1
src: remove unused header added by mistake
alferpal Nov 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
src: include base_object in module_wrap.h 
Include the plain header file instead of its inline counterpart
  • Loading branch information
@alferpal
alferpal committed Nov 28, 2019
commit 240ba7d1e8ed2703dc07e9246529646fa2e823ce
2 changes: 1 addition & 1 deletion src/module_wrap.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
#include <unordered_map>
#include <string>
#include <vector>
#include "base_object-inl.h"
#include "base_object.h"

namespace node {

Expand Down