Skip to content

test: do not run release-npm test without crypto #30265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
targos wants to merge 2 commits into from
Closed

test: do not run release-npm test without crypto #30265

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ef67c7
test: do not run release-npm test without crypto
targos Nov 5, 2019
3a67c15
fixup! test: do not run release-npm test without crypto
targos Nov 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: do not run release-npm test without crypto 
npm requires crypto support and cannot be loaded without it.
  • Loading branch information
@targos
targos committed Nov 5, 2019
commit 1ef67c7ec1c6618162b3eeb1a69bac228d859757
5 changes: 3 additions & 2 deletions test/parallel/test-release-npm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,13 @@ const path = require('path');

const releaseReg = /^v\d+\.\d+\.\d+$/;

if (!releaseReg.test(process.version)) {
// npm requires crypto support.
if (!releaseReg.test(process.version) || !common.hasCrypto) {
common.skip('This test is only for release builds');
}

{
// Verify that npm does not print out a warning when executed
// Verify that npm does not print out a warning when executed.

const npmCli = path.join(__dirname, '../../deps/npm/bin/npm-cli.js');
const npmExec = child_process.spawnSync(process.execPath, [npmCli]);
Expand Down