Skip to content

http: fix incorrect headersTimeout measurement #30184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
OrKoN wants to merge 5 commits into from
Closed

http: fix incorrect headersTimeout measurement #30184

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f7281ca
http: fix incorrect headersTimeout measurement
OrKoN Oct 30, 2019
8cfd1b8
test: fix flaky test-http-highwatermark
OrKoN Oct 31, 2019
aa83993
http: add nowDate() to async scope
OrKoN Nov 1, 2019
845d4bb
http: use nullptr to fix win build
OrKoN Jan 5, 2020
01c2228
http: revert flaky test fix
OrKoN Jan 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
http: add nowDate() to async scope
  • Loading branch information
@OrKoN
OrKoN committed Mar 17, 2020
commit aa8399326e5c8ffbffa90b7887d7c8dd00b7eed8
1 change: 1 addition & 0 deletions lib/_http_server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,6 +429,7 @@ function connectionListenerInternal(server, socket) {
isLenient() : server.insecureHTTPParser,
);
parser.socket = socket;
parser.parsingHeadersStart = nowDate();
socket.parser = parser;

// Propagate headers limit from server instance to parser
Expand Down