Skip to content

fs.watch throws exception when recursive is used in incompatible platform #29947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
exx8 wants to merge 15 commits into from
Closed

fs.watch throws exception when recursive is used in incompatible platform #29947

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
fa5984b
fs: watch signals for recursive incompatibility
Oct 12, 2019
b731dac
Some lints to the fs.js file.
Oct 12, 2019
20d6e4c
A new error ERR_OPTION_INCOMPATIBLE_WITH_PLATFORM is added to node.
Oct 12, 2019
98e7561
update the relevant test: if on win or osx no exception should be thr…
Oct 12, 2019
d985a42
Documenting the new changes:
Oct 12, 2019
bdb2a7d
A style change
exx8 Oct 12, 2019
c6373f3
fix according to review
Oct 13, 2019
194ca4d
fix to documentation
Oct 13, 2019
a0b5dd5
Update doc/api/fs.md
exx8 Oct 14, 2019
b0fc0eb
Update doc/api/fs.md
exx8 Oct 14, 2019
cb24297
Update lib/internal/errors.js
exx8 Oct 14, 2019
7e23cef
reformatting the error definition, and refactor the test
Oct 15, 2019
120a471
updating test.
Oct 15, 2019
632c0e1
fixup! updating test.
Trott Jan 24, 2020
b3db344
fixup! fixup! updating test.
Trott Jan 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update lib/internal/errors.js 
Co-Authored-By: Ben Noordhuis <info@bnoordhuis.nl>
  • Loading branch information
@exx8 @bnoordhuis @Trott
2 people authored and Trott committed Jan 24, 2020
commit cb2429734f311636845aeeb1fb372dab803de62f
2 changes: 1 addition & 1 deletion lib/internal/errors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -805,7 +805,7 @@ E('ERR_FALSY_VALUE_REJECTION', function(reason) {
}, Error);
E('ERR_FEATURE_UNAVAILABLE_ON_PLATFORM',
(feature) => 'The feature ' + feature +
' is unavailable to the current platform' +
' is unavailable on the current platform' +
', which is being used to run Node.js', TypeError);
E('ERR_FS_FILE_TOO_LARGE', 'File size (%s) is greater than 2 GB', RangeError);
E('ERR_FS_INVALID_SYMLINK_TYPE',
Expand Down