Skip to content

module: warn on using unfinished circular dependency #29935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 3 commits into from
Closed

module: warn on using unfinished circular dependency #29935

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eaa5cc5
module: warn on using unfinished circular dependency
addaleax Oct 11, 2019
dd1cdfa
fixup! module: warn on using unfinished circular dependency
addaleax Oct 11, 2019
3ba4313
fixup! module: warn on using unfinished circular dependency
addaleax Oct 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! module: warn on using unfinished circular dependency
  • Loading branch information
@addaleax
addaleax committed Oct 11, 2019
commit dd1cdfa7801429935ee1e866c89e32ce514427f5
4 changes: 3 additions & 1 deletion test/fixtures/cycles/warning-b.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,3 @@
require('./warning-a.js').missingPropB;
const a = require('./warning-a.js');
a.missingPropB;
a[Symbol('someSymbol')];
2 changes: 2 additions & 0 deletions test/parallel/test-module-circular-dependency-warning.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ common.expectWarning({
Warning: [
["Accessing non-existent property 'missingPropB' " +
'of module exports inside circular dependency'],
["Accessing non-existent property 'Symbol(someSymbol)' " +
'of module exports inside circular dependency'],
["Accessing non-existent property 'missingPropModuleExportsB' " +
'of module exports inside circular dependency']
]
Expand Down