Skip to content

stream: added note about undocumented API #29805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ronag wants to merge 2 commits into from
Closed

stream: added note about undocumented API #29805

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9fbf8a1
stream: added note about undocumented API
ronag Oct 1, 2019
4c56e4c
fixup: typo
ronag Oct 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/internal/streams/destroy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ function needError(stream, err) {
return true;
}

// Undocumented cb() API, needed for core, not for public API
// Undocumented cb() API, needed for core, not for public API.
// cb() well be invoked synchronously if _destroy is synchronous.
Comment thread
ronag marked this conversation as resolved.
Resolved
function destroy(err, cb) {
const r = this._readableState;
const w = this._writableState;
Expand Down