Skip to content

Patches to help build node as a shared library for Android #29388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gcampax wants to merge 2 commits into from
Closed

Patches to help build node as a shared library for Android #29388

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
77c2273
build: fix library version and compile flags on Android
gcampax Sep 24, 2017
f18b9da
build: on Android, use android log library to print stack traces
gcampax Sep 24, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
build: on Android, use android log library to print stack traces 
And other errors like lost promises
  • Loading branch information
@gcampax
gcampax committed Oct 22, 2019
commit f18b9dafbcc37110c3ed9c0a6da71f1fbd9129b1
6 changes: 6 additions & 0 deletions src/node_errors.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@
#include "node_v8_platform-inl.h"
#include "util-inl.h"

#ifdef __ANDROID__
#include <android/log.h>
#endif

namespace node {

using errors::TryCatchScope;
Expand Down Expand Up @@ -413,6 +417,8 @@ void PrintErrorString(const char* format, ...) {
// Don't include the null character in the output
CHECK_GT(n, 0);
WriteConsoleW(stderr_handle, wbuf.data(), n - 1, nullptr, nullptr);
#elif defined(__ANDROID__)
__android_log_vprint(ANDROID_LOG_ERROR, "nodejs", format, ap);

@gengjiawen gengjiawen Oct 22, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nodejs -> Node.js

#else
vfprintf(stderr, format, ap);
#endif
Expand Down