Skip to content

http: reset parser.incoming when server request is finished #29297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 4 commits into from
Closed

http: reset parser.incoming when server request is finished #29297

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
40a2a8e
http: reset parser.incoming when server request is finished
addaleax Aug 24, 2019
5cd5402
fixup! http: reset parser.incoming when server request is finished
addaleax Aug 24, 2019
6232470
fixup! http: reset parser.incoming when server request is finished
addaleax Aug 24, 2019
18637be
fixup! http: reset parser.incoming when server request is finished
addaleax Aug 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! http: reset parser.incoming when server request is finished
  • Loading branch information
@addaleax
addaleax committed Aug 24, 2019
commit 6232470fa0deb756ce1c654a1ee9433e878b64ba
8 changes: 5 additions & 3 deletions lib/_http_server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -611,13 +611,15 @@ function onParserExecuteCommon(server, socket, parser, state, ret, d) {
}
}

function clearIncoming(parser, req) {
function clearIncoming(req) {
req = req || this;
const parser = req.socket && req.socket.parser;
// Reset the .incoming property so that the request object can be gc'ed.
if (parser && parser.incoming === req) {
if (req.readableEnded) {
parser.incoming = null;
} else {
req.on('end', clearIncoming.bind(null, parser, req));
req.on('end', clearIncoming);
}
}
}
Expand All @@ -629,7 +631,7 @@ function resOnFinish(req, res, socket, state, server) {
assert(state.incoming.length === 0 || state.incoming[0] === req);

state.incoming.shift();
clearIncoming(socket.parser, req);
clearIncoming(req);

// If the user never called req.read(), and didn't pipe() or
// .resume() or .on('data'), then we call req._dump() so that the
Expand Down