Skip to content

fs: allow passing true to emitClose option #29212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gntem wants to merge 4 commits into from
Closed

fs: allow passing true to emitClose option #29212

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
df1ba97
fs: allow passing true to emitClose option
gntem Aug 19, 2019
93c1f17
test: add `emitClose: true` tests for fs streams
Trott Aug 22, 2019
3bb7bf4
doc: add emitClose option for fs streams
Trott Aug 22, 2019
08d515f
doc: removed parentheses from fs doc
gntem Aug 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: add emitClose: true tests for fs streams
  • Loading branch information
@Trott
Trott committed Aug 22, 2019
commit 93c1f17ec2861d602b263b9450d19b127873d9fa
27 changes: 25 additions & 2 deletions test/parallel/test-fs-stream-destroy-emit-error.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,31 @@ const fs = require('fs');
const tmpdir = require('../common/tmpdir');
tmpdir.refresh();

test(fs.createReadStream(__filename));
test(fs.createWriteStream(`${tmpdir.path}/dummy`));
{
const stream = fs.createReadStream(__filename);
stream.on('close', common.mustNotCall());
test(stream);
}

{
const stream = fs.createWriteStream(`${tmpdir.path}/dummy`);
stream.on('close', common.mustNotCall());
test(stream);
}

{
const stream = fs.createReadStream(__filename, { emitClose: true });
stream.on('close', common.mustCall());
test(stream);
}

{
const stream = fs.createWriteStream(`${tmpdir.path}/dummy2`,
{ emitClose: true });
stream.on('close', common.mustCall());
test(stream);
}


function test(stream) {
const err = new Error('DESTROYED');
Expand Down