Skip to content

src: use libuv to get env vars #29188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 4 commits into from
Closed

src: use libuv to get env vars #29188

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ef68e58
benchmark: improve process.env benchmarks
addaleax Aug 17, 2019
02fdce6
src: use libuv to get env vars
addaleax Aug 17, 2019
e75c72e
fixup! src: use libuv to get env vars
addaleax Sep 13, 2019
eed2884
fixup! fixup! src: use libuv to get env vars
addaleax Sep 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! fixup! src: use libuv to get env vars
  • Loading branch information
@addaleax
addaleax committed Sep 18, 2019
commit eed28843b772f5ec8483415023b1793a90611544
5 changes: 3 additions & 2 deletions src/node_env_var.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,7 @@ Local<Array> RealEnvStore::Enumerate(Isolate* isolate) const {
CHECK_EQ(uv_os_environ(&items, &count), 0);

MaybeStackBuffer<Local<Value>, 256> env_v(count);
int env_v_index = 0;
for (int i = 0; i < count; i++) {
#ifdef _WIN32
// If the key starts with '=' it is a hidden environment variable.
Expand All @@ -166,10 +167,10 @@ Local<Array> RealEnvStore::Enumerate(Isolate* isolate) const {
isolate->ThrowException(ERR_STRING_TOO_LONG(isolate));
return Local<Array>();
}
env_v[i] = str.ToLocalChecked();
env_v[env_v_index++] = str.ToLocalChecked();
}

return Array::New(isolate, env_v.out(), env_v.length());
return Array::New(isolate, env_v.out(), env_v_index);
}

std::shared_ptr<KVStore> KVStore::Clone(v8::Isolate* isolate) const {
Expand Down