Skip to content

src: large pages option: FreeBSD support proposal #28331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
devnexen wants to merge 3 commits into from
Closed

src: large pages option: FreeBSD support proposal #28331

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a0ba372
src: large pages option: FreeBSD support proposal
devnexen Jun 20, 2019
afd5ddb
Further tweaks from review
devnexen Jun 21, 2019
4abe537
Wrong line the aligned data vector needs the proper value before allo…
devnexen Jun 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Wrong line the aligned data vector needs the proper value before allo… 
…cation
  • Loading branch information
@devnexen
devnexen committed Jul 7, 2019
commit 4abe537ce5620b8475d315043ce4b16bf87ccc97
6 changes: 3 additions & 3 deletions src/large_pages/node_large_page.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,10 +170,10 @@ static struct text_region FindNodeTextRegion() {
return nregion;
}

auto alg = std::vector<char>(numpg);

// for struct kinfo_vmentry
numpg = numpg * 4 / 3;

@bnoordhuis bnoordhuis Jun 22, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take your word for it that that is big enough. ^^

auto alg = std::vector<char>(numpg);

if (sysctl(mib, miblen, alg.data(), &numpg, nullptr, 0) == -1) {
return nregion;
}
Expand Down Expand Up @@ -354,7 +354,7 @@ MoveTextRegionToLargePages(const text_region& r) {
int MapStaticCodeToLargePages() {
struct text_region r = FindNodeTextRegion();
if (r.found_text_region == false) {
fprintf(stderr, "Hugepages WARNING: failed to find text regionn");
fprintf(stderr, "Hugepages WARNING: failed to find text region\n");
return -1;
}

Expand Down