Skip to content

process: code cleanup for nextTick #28047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
apapirovski wants to merge 5 commits into from
Closed

process: code cleanup for nextTick #28047

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1a66c0d
process: code cleanup for nextTick
apapirovski Jun 2, 2019
8c8c730
fixup: add destroy hook test
apapirovski Jun 5, 2019
c5c3c6f
fixup: add comment explaining the test
apapirovski Jun 5, 2019
20f2a93
fixup: make test work in workers
apapirovski Jun 7, 2019
83658f7
fixup: typo
apapirovski Jun 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup: make test work in workers
  • Loading branch information
@apapirovski
apapirovski committed Jun 7, 2019
commit 20f2a93b55a83c8c5faf678732f395f060df2783
12 changes: 11 additions & 1 deletion test/async-hooks/test-late-hook-enable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,17 @@ const async_hooks = require('async_hooks');
// Checks that enabling async hooks in a callback actually
// triggers after & destroy as expected.

const fnsToTest = [setTimeout, setImmediate, (cb) => {
const fnsToTest = [setTimeout, (cb) => {
setImmediate(() => {
cb();

// We need to keep the event loop open for this to actually work
// since destroy hooks are triggered in unrefed Immediates
setImmediate(() => {
hook.disable();
});
})
}, (cb) => {
process.nextTick(() => {
cb();

Expand Down