Skip to content

worker: add typechecking for postMessage transfer list #28033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 4 commits into from
Closed

worker: add typechecking for postMessage transfer list #28033

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7580ecb
worker: add typechecking for postMessage transfer list
addaleax Jun 2, 2019
5c9f1c6
fixup! worker: add typechecking for postMessage transfer list
addaleax Jun 9, 2019
8aac5b2
fixup! worker: add typechecking for postMessage transfer list
addaleax Jun 9, 2019
ace5dff
fixup! worker: add typechecking for postMessage transfer list
addaleax Jun 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! worker: add typechecking for postMessage transfer list
  • Loading branch information
@addaleax
addaleax committed Jun 9, 2019
commit 8aac5b20816d42a4935fb2f2d145963d5bf48eb9
8 changes: 5 additions & 3 deletions src/node_messaging.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -712,9 +712,11 @@ void MessagePort::PostMessage(const FunctionCallbackInfo<Value>& args) {
"MessagePort.postMessage");
}
if (!args[1]->IsNullOrUndefined() && !args[1]->IsObject()) {
// Browsers also do not throw on `null` or objects, although it really
// should be an array or undefined, thus the mismatch between the checks
// above and the actual error message.
// Browsers ignore null or undefined, and otherwise accept an array or an
// options object.
// TODO(addaleax): Add support for an options object and generic sequence
// support.
// Refs: https://github.com/nodejs/node/pull/28033#discussion_r289964991
return THROW_ERR_INVALID_ARG_TYPE(env,
"Optional transferList argument must be an array");
}
Expand Down