Skip to content

worker: use DataCloneError for unknown native objects #28025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 2 commits into from
Closed

worker: use DataCloneError for unknown native objects #28025

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2e9c52
worker: use DataCloneError for unknown native objects
addaleax Jun 2, 2019
07a77f6
fixup! worker: use DataCloneError for unknown native objects
addaleax Jun 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! worker: use DataCloneError for unknown native objects
  • Loading branch information
@addaleax
addaleax committed Jun 2, 2019
commit 07a77f63b1f3a99063eb9e013538071cf2d92c06
10 changes: 8 additions & 2 deletions test/parallel/test-worker-message-port-transfer-native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,10 @@ const { internalBinding } = require('internal/test/binding');

assert.throws(() => {
port1.postMessage(function foo() {});
}, /^DataCloneError: function foo\(\) \{\} could not be cloned\.$/);
}, {
name: 'DataCloneError',
message: /function foo\(\) \{\} could not be cloned\.$/
});
port1.close();
}

Expand All @@ -26,6 +29,9 @@ const { internalBinding } = require('internal/test/binding');

assert.throws(() => {
port1.postMessage(nativeObject);
}, /^DataCloneError: Cannot transfer object of unsupported type\.$/);
}, {
name: 'DataCloneError',
message: /Cannot transfer object of unsupported type\.$/
});
port1.close();
}