Skip to content

process: disallow some uses of Object.defineProperty() on process.env #28006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 4 commits into from
Apr 4, 2022
Merged

process: disallow some uses of Object.defineProperty() on process.env #28006

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e65bb10
process: disallow some uses of Object.defineProperty() on process.env
himself65 Jun 3, 2019
37f2243
fixup! edit error message
himself65 Jan 11, 2022
6ad7bdc
fixup! format
himself65 Jan 13, 2022
46acbbe
Update doc/api/errors.md
himself65 Jan 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! format
  • Loading branch information
@himself65
himself65 committed Jan 13, 2022
commit 6ad7bdcbf6180312d40ac7eba8d44c5927cf9765
16 changes: 11 additions & 5 deletions src/node_env_var.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,25 +408,31 @@ static void EnvDefiner(Local<Name> property,
THROW_ERR_INVALID_OBJECT_DEFINE_PROPERTY(env,
"'process.env' only accepts a "
"configurable, writable,"
" and enumerable data descriptor");
} else if (!desc.configurable() || !desc.enumerable() || !desc.writable()) {
" and enumerable "
"data descriptor");
} else if (!desc.configurable() ||
!desc.enumerable() ||
!desc.writable()) {
THROW_ERR_INVALID_OBJECT_DEFINE_PROPERTY(env,
"'process.env' only accepts a "
"configurable, writable,"
" and enumerable data descriptor");
" and enumerable "
"data descriptor");
} else {
return EnvSetter(property, desc.value(), info);
}
} else if (desc.has_get() || desc.has_set()) {
// we don't accept a getter/setter in 'process.env'
THROW_ERR_INVALID_OBJECT_DEFINE_PROPERTY(env,
"'process.env' does not accept an"
"accessor(getter/setter) descriptor");
"accessor(getter/setter)"
" descriptor");
} else {
THROW_ERR_INVALID_OBJECT_DEFINE_PROPERTY(env,
"'process.env' only accepts a "
"configurable, writable,"
" and enumerable data descriptor");
" and enumerable "
"data descriptor");
}
}

Expand Down