Skip to content

test: finish code coverage for lib/internal/worker.js #27995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Trott merged 2 commits into from
Jun 2, 2019
Merged

test: finish code coverage for lib/internal/worker.js #27995

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04053c4
test: add coverage for unserializable worker thread error
Trott May 31, 2019
e8f3119
test: handle unknown message type in worker threads
Trott May 31, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: handle unknown message type in worker threads 
Check that main thread handles an unknown message type from a worker
thread as expected.

PR-URL: #27995
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
@Trott
Trott committed Jun 2, 2019
commit e8f31191902a8304f77f7ed4377f10de91aca103
17 changes: 8 additions & 9 deletions test/parallel/test-worker-message-not-serializable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,20 +6,19 @@
// expected.

const common = require('../common');
common.skipIfWorker();

const assert = require('assert');

const { Worker, isMainThread } = require('worker_threads');
if (isMainThread) {
const worker = new Worker(__filename);
worker.on('error', common.mustCall((e) => {
assert.strictEqual(e.code, 'ERR_WORKER_UNSERIALIZABLE_ERROR');
}));
} else {
const { Worker } = require('worker_threads');

const worker = new Worker(`
const { internalBinding } = require('internal/test/binding');
const { getEnvMessagePort } = internalBinding('worker');
const { messageTypes } = require('internal/worker/io');
const messagePort = getEnvMessagePort();
messagePort.postMessage({ type: messageTypes.COULD_NOT_SERIALIZE_ERROR });
}
`, { eval: true });

worker.on('error', common.mustCall((e) => {
assert.strictEqual(e.code, 'ERR_WORKER_UNSERIALIZABLE_ERROR');
}));
25 changes: 25 additions & 0 deletions test/parallel/test-worker-message-type-unknown.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
'use strict';

// Check that main thread handles an unknown message type from a worker thread
// as expected.

require('../common');

const assert = require('assert');
const { spawnSync } = require('child_process');

const { Worker } = require('worker_threads');
if (process.argv[2] !== 'spawned') {
const result = spawnSync(process.execPath,
[ '--expose-internals', __filename, 'spawned'],
{ encoding: 'utf8' });
assert.ok(result.stderr.includes('Unknown worker message type FHQWHGADS'),
`Expected error not found in: ${result.stderr}`);
} else {
new Worker(`
const { internalBinding } = require('internal/test/binding');
const { getEnvMessagePort } = internalBinding('worker');
const messagePort = getEnvMessagePort();
messagePort.postMessage({ type: 'FHQWHGADS' });
`, { eval: true });
}