Skip to content

v12.3.1 proposal #27814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BridgeAR merged 5 commits into from
May 22, 2019
Merged

v12.3.1 proposal #27814

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
aed74cc
deps: upgrade to libuv 1.29.1
cjihrig May 15, 2019
6f70054
src, lib: take control of prepareStackTrace
devsnek Mar 19, 2019
7438a55
src: remove util-inl.h include in node.h
addaleax May 21, 2019
c478884
deps: V8: cherry-pick 94c87fe
targos May 21, 2019
2817fde
2019-05-22, Version v12.3.1 (Current)
BridgeAR May 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
src: remove util-inl.h include in node.h 
`node.h` may only include public APIs, which `util-inl.h` is not.
There does not seem to be any reason for including it, so remove it,
because otherwise native addon compilation is broken due to us not
shipping the `util-inl.h` header.

Refs: #27631
Fixes: #27803

PR-URL: #27804
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
  • Loading branch information
@addaleax @BridgeAR
addaleax authored and BridgeAR committed May 22, 2019
commit 7438a557af191595b23f103cae73ee79c23bdb9e
8 changes: 0 additions & 8 deletions src/node.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,14 +99,6 @@
# endif
#endif

#if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS
// Internally, do not include util-inl.h into files unless they need it's
// inline definitions.
#else
// Externally, it must be included for backwards API compatibility.
# include <util-inl.h>
#endif

// Forward-declare libuv loop
struct uv_loop_s;

Expand Down