Skip to content

n-api: do not require JS Context for napi_async_destroy() #27255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 4 commits into from
Closed

n-api: do not require JS Context for napi_async_destroy() #27255

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7947f48
src: add `Environment` overload of `EmitAsyncDestroy`
addaleax Apr 16, 2019
4128307
n-api: do not require JS Context for `napi_async_destroy()`
addaleax Apr 16, 2019
66f6944
src: do not require JS Context for `~AsyncResoure()`
addaleax Apr 16, 2019
f880b4f
fixup! n-api: do not require JS Context for `napi_async_destroy()`
addaleax Apr 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! n-api: do not require JS Context for napi_async_destroy()
  • Loading branch information
@addaleax
addaleax committed Apr 16, 2019
commit f880b4f9f187032f8c9da0bc4a31e90b5366b6a4
2 changes: 2 additions & 0 deletions test/node-api/test_make_callback/binding.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ static napi_value MakeCallback(napi_env env, napi_callback_info info) {

static void AsyncDestroyCb(napi_env env, void* data, void* hint) {
napi_status status = napi_async_destroy(env, (napi_async_context)data);
// We cannot use NAPI_ASSERT_RETURN_VOID because we need to have a JS stack
// below in order to use exceptions.
assert(status == napi_ok);
Comment thread
addaleax marked this conversation as resolved.
Resolved
}

Expand Down