Skip to content

src: simplify loop arithmetic in GetCPUInfo #26183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gireeshpunathil wants to merge 5 commits into from
Closed

src: simplify loop arithmetic in GetCPUInfo #26183

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
80bb198
src: simplify loop arithmetic in `GetCPUInfo`
gireeshpunathil Feb 18, 2019
2427f3e
fixup: address review comments
gireeshpunathil Feb 19, 2019
23cafc9
fixup: address review comments 2
gireeshpunathil Feb 19, 2019
1666fa5
fixup: address review comments
gireeshpunathil Feb 19, 2019
f1798dd
fixup: correct the loop iteration variable
gireeshpunathil Feb 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup: address review comments 2
  • Loading branch information
@gireeshpunathil
gireeshpunathil committed Feb 19, 2019
commit 23cafc976d3833fc013d8230acfd887558d86e6c
2 changes: 1 addition & 1 deletion src/node_os.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ static void GetCPUInfo(const FunctionCallbackInfo<Value>& args) {
// The array is in the format
// [model, speed, (5 entries of cpu_times), model2, speed2, ...]
std::vector<Local<Value>> result(count * 7);
for (int i = 0, j = 0; i < count; i++, j = i * 7) {
for (int i = 0, j = 0; i < count; i++) {
uv_cpu_info_t* ci = cpu_infos + i;
result[j++] = OneByteString(isolate, ci->model);
result[j++] = Number::New(isolate, ci->speed);
Expand Down