Skip to content

Makes http(2) response.writehead return this #25974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
qubyte wants to merge 7 commits into from
Closed

Makes http(2) response.writehead return this #25974

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2e265aa
http: makes response.writeHead return the response
qubyte Feb 6, 2019
bd6803d
http2: makes response.writeHead return the response
qubyte Feb 6, 2019
1ce1dcc
http: update to documentation
addaleax Feb 7, 2019
3a4d057
http2: update to documentation
addaleax Feb 7, 2019
2f476b6
http2: update to documentation
vsemozhetbyt Feb 7, 2019
c5d4090
http: update to documentation
vsemozhetbyt Feb 7, 2019
df45bdc
http2: update to documentation
vsemozhetbyt Feb 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
http2: update to documentation 
Addresses PR feedback.

Co-Authored-By: qubyte <mark.s.everitt@gmail.com>
  • Loading branch information
@addaleax @qubyte
addaleax and qubyte authored Feb 7, 2019
commit 3a4d057bd694ab17469a9486d0adce8ab9c79f09
2 changes: 1 addition & 1 deletion doc/api/http2.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3284,7 +3284,7 @@ should be sent. See the [`'checkContinue'`][] event on `Http2Server` and
<!-- YAML
added: v8.4.0
changes:
- version: ???
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/25974
description: Return `this` from `writeHead` to allow chaining with `end`.
Comment thread
qubyte marked this conversation as resolved.
Outdated
-->
Expand Down