Skip to content

process: expose process.features.inspector #25819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joyeecheung wants to merge 4 commits into from
Closed

process: expose process.features.inspector #25819

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
731f799
process: expose process.features.inspector
joyeecheung Jan 30, 2019
66aebeb
fixup! process: expose process.features.inspector
joyeecheung Jan 30, 2019
137426e
fixup! process: expose process.features.inspector
refack Jan 30, 2019
67e20d1
fixup! fixup! process: expose process.features.inspector
joyeecheung Jan 31, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! process: expose process.features.inspector
  • Loading branch information
@joyeecheung
joyeecheung committed Jan 30, 2019
commit 66aebeb0d3fee48c6f9745a22d7edab2862e5b35
12 changes: 6 additions & 6 deletions src/node_config.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,18 +57,18 @@ static void Initialize(Local<Object> target,
READONLY_TRUE_PROPERTY(target, "hasTracing");
#endif

#if HAVE_INSPECTOR
READONLY_TRUE_PROPERTY(target, "hasInspector");
#else
READONLY_FALSE_PROPERTY(target, "hasInspector");
#endif

#if !defined(NODE_WITHOUT_NODE_OPTIONS)
READONLY_TRUE_PROPERTY(target, "hasNodeOptions");
#endif

#endif // NODE_HAVE_I18N_SUPPORT

#if HAVE_INSPECTOR
READONLY_TRUE_PROPERTY(target, "hasInspector");
#else
READONLY_FALSE_PROPERTY(target, "hasInspector");
#endif

if (env->abort_on_uncaught_exception())
READONLY_TRUE_PROPERTY(target, "shouldAbortOnUncaughtException");

Expand Down
7 changes: 0 additions & 7 deletions test/common/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -622,12 +622,6 @@ function skipIfInspectorDisabled() {
}
}

function skipIfInspectorEnabled() {
if (process.features.inspector) {
skip('V8 inspector is enabled');
}
}

function skipIfReportDisabled() {
if (!process.config.variables.node_report) {
skip('Node Report is disabled');
Expand Down Expand Up @@ -759,7 +753,6 @@ module.exports = {
skipIf32Bits,
skipIfEslintMissing,
skipIfInspectorDisabled,
skipIfInspectorEnabled,
skipIfReportDisabled,
skipIfWorker,

Expand Down
4 changes: 3 additions & 1 deletion test/sequential/test-inspector-has-inspector-false.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@

const common = require('../common');

common.skipIfInspectorEnabled();
if (process.features.inspector) {
common.skip('V8 inspector is enabled');
}

const inspector = require('internal/util/inspector');

Expand Down