Skip to content

repl: minor improvements #25731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BridgeAR wants to merge 4 commits into from
Closed

repl: minor improvements #25731

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9c668c2
repl: simplify and improve completion
BridgeAR Jan 25, 2019
0542890
repl: fix eval return value
BridgeAR Jan 27, 2019
240388c
repl: remove obsolete buffer clearing
BridgeAR Jan 27, 2019
12a3e4d
test: remove obsolete code
BridgeAR Jan 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
repl: remove obsolete buffer clearing 
It is checked if an command buffer exists or not. This code branch
can only be reached if non exist, so there's no need to clear that
buffer again.
  • Loading branch information
@BridgeAR
BridgeAR committed Jan 27, 2019
commit 240388c2028e0b77065858171e06cf9b9ad5b61d
1 change: 0 additions & 1 deletion lib/repl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -637,7 +637,6 @@ function REPLServer(prompt,
self.outputStream.write('npm should be run outside of the ' +
'node repl, in your normal shell.\n' +
'(Press Control-D to exit.)\n');
self.clearBufferedCommand();
self.displayPrompt();
return;
}
Expand Down