Skip to content

when a HTTP header overflow error occurs, instead of a generic 400 response, return 431 Request Header Fields Too Large #25605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
albertstill wants to merge 2 commits into from
Closed

when a HTTP header overflow error occurs, instead of a generic 400 response, return 431 Request Header Fields Too Large #25605

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50b7711
lib,test: return HTTP 431 on HPE_HEADER_OVERFLOW error
albertstill Jan 21, 2019
cd1e61c
doc: http.Server clientError default behavior slightly changed
albertstill Jan 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
doc: http.Server clientError default behavior slightly changed 
Explain that in the case of a HPE_HEADER_OVERFLOW
error Node.js will return a 431 Request Header Fields Too Large.

PR-URL: #25605
  • Loading branch information
@albertstill
albertstill committed Feb 1, 2019
commit cd1e61ccb949c77d8b016f0563c195cb2843e1f3
11 changes: 9 additions & 2 deletions doc/api/http.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -829,6 +829,10 @@ changes:
description: The `rawPacket` is the current buffer that just parsed. Adding
this buffer to the error object of `'clientError'` event is to
make it possible that developers can log the broken packet.
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/25605
description: The default behavior will return a 431 Request Header
Fields Too Large if a HPE_HEADER_OVERFLOW error occurs.
-->

* `exception` {Error}
Expand All @@ -839,8 +843,10 @@ Listener of this event is responsible for closing/destroying the underlying
socket. For example, one may wish to more gracefully close the socket with a
custom HTTP response instead of abruptly severing the connection.

Default behavior is to close the socket with an HTTP '400 Bad Request' response
if possible, otherwise the socket is immediately destroyed.
Default behavior is to try close the socket with a HTTP '400 Bad Request',
Comment thread
mcollina marked this conversation as resolved.
Resolved
or a HTTP '431 Request Header Fields Too Large' in the case of a
[`HPE_HEADER_OVERFLOW`][] error. If the socket is not writable it is
immediately destroyed.

`socket` is the [`net.Socket`][] object that the error originated from.

Expand Down Expand Up @@ -2171,3 +2177,4 @@ not abort the request or do anything besides add a `'timeout'` event.
[`url.parse()`]: url.html#url_url_parse_urlstring_parsequerystring_slashesdenotehost
[Readable Stream]: stream.html#stream_class_stream_readable
[Stream]: stream.html#stream_stream
[`HPE_HEADER_OVERFLOW`]: errors.html#errors_hpe_header_overflow