Skip to content

modules: significantly improve require performance #25362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BridgeAR wants to merge 16 commits into from
Closed

modules: significantly improve require performance #25362

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
bbfe4a3
benchmark: add new module loading benchmarks
BridgeAR Jan 2, 2019
9c54e43
modules: significantly improve repeated requires
BridgeAR Dec 30, 2018
23eee46
fixup: changed signature on master
BridgeAR Jan 6, 2019
ab5d408
fixup: add line back
BridgeAR Jan 6, 2019
f447111
fixup: typo
BridgeAR Jan 6, 2019
fc0493a
fixup: remove minor breaking change
BridgeAR Jan 6, 2019
e625fb8
fixup: remove obsolete internals check
BridgeAR Jan 6, 2019
c7a9751
fixup: add backwards compat fix
BridgeAR Jan 6, 2019
d8aca04
fixup: address long sentence
BridgeAR Jan 6, 2019
5de8e71
fixup: check internal modules first
BridgeAR Jan 6, 2019
ba9c391
fixup: try using an own object
BridgeAR Jan 6, 2019
34a1785
fixup: smaller code
BridgeAR Jan 6, 2019
554c5ac
fixup: faster internal check
BridgeAR Jan 6, 2019
38afefb
fixup: make sure extension symbols are ignored
BridgeAR Jan 6, 2019
7194285
fixup: keep backwards compatible return value
BridgeAR Jan 6, 2019
59116ac
fixup: improve benchmarks
BridgeAR Jan 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup: try using an own object 
There are some issues involving the proxy. This tries to circumvent
the issue by not making any copy of the newly set object.
  • Loading branch information
@BridgeAR
BridgeAR committed Jan 6, 2019
commit ba9c391fbc5bc6331bcc634e8fb22d3bd75612a9
15 changes: 9 additions & 6 deletions lib/internal/modules/cjs/loader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -744,26 +744,29 @@ if (experimentalModules) {
function setExtensionsProxy(extensions) {
// Intersect manipulating the extensions.
extensionNames = Object.keys(extensions);
extensionCopy = { ...extensions };
extensionCopy = Object.create(null);
for (const name of extensionNames) {
extensionCopy[name] = true;
}

@jdalton jdalton Jan 8, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like an awful lot of work for to avoid Object.keys here.
How much is the win here for just Object.keys? Can we leave this whole Proxy of the Module out and still get the majority of the wins?

return new Proxy(extensions, {
set(obj, prop, value) {
if (extensions[prop] === undefined) {
extensionCopy[prop] = value;
if (extensionCopy[prop] === undefined) {
extensionCopy[prop] = true;
extensionNames.push(prop);
}
return Reflect.set(obj, prop, value);
},
defineProperty(target, prop, descriptor) {
if (extensions[prop] === undefined) {
Object.defineProperty(extensionCopy, prop, descriptor);
if (extensionCopy[prop] === undefined) {
extensionCopy[prop] = true;
extensionNames.push(prop);
}
return Reflect.defineProperty(target, prop, descriptor);
},
deleteProperty(target, prop) {
const pos = extensionNames.indexOf(prop);
if (pos !== -1) {
delete extensionCopy[prop];
extensionCopy[prop] = false;
extensionNames.splice(pos, 1);
}
return Reflect.deleteProperty(target, prop);
Expand Down