Skip to content

path: reduce path code size #25278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BridgeAR wants to merge 8 commits into from
Closed

path: reduce path code size #25278

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0584d41
path: minor refactoring
BridgeAR Jan 27, 2019
317013c
path: more small refactorings
BridgeAR Jan 27, 2019
471192b
path: refactor more path code for simplicity
BridgeAR Jan 27, 2019
ace9215
path: minor refactoring
BridgeAR Jan 27, 2019
6b2c7a2
path: refactor logic for to reduce code branches
BridgeAR Jan 27, 2019
a815e20
path: simplify code and remove obsolete checks
BridgeAR Jan 27, 2019
5b5cebb
path: refactor for less indentation
BridgeAR Jan 27, 2019
5da1b22
path: refactor code for clarity
BridgeAR Jan 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
path: refactor logic for to reduce code branches 
This refactoring makes sure some code branches will not be hit if
they do not have to be reached.
  • Loading branch information
@BridgeAR
BridgeAR committed Feb 28, 2019
commit 6b2c7a2fdcc39c8bec9696d336830f168526b4f1
30 changes: 16 additions & 14 deletions lib/path.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,23 +224,25 @@ const win32 = {
isAbsolute = true;
}

if (device.length > 0 &&
resolvedDevice.length > 0 &&
device.toLowerCase() !== resolvedDevice.toLowerCase()) {
// This path points to another device so it is not applicable
continue;
if (device.length > 0) {
if (resolvedDevice.length > 0) {
if (device.toLowerCase() !== resolvedDevice.toLowerCase())
// This path points to another device so it is not applicable
continue;
} else {
resolvedDevice = device;
}
}

if (resolvedDevice.length === 0 && device.length > 0) {
resolvedDevice = device;
}
if (!resolvedAbsolute) {
resolvedTail = path.slice(rootEnd) + '\\' + resolvedTail;
if (resolvedAbsolute) {
if (resolvedDevice.length > 0)
break;
} else {
resolvedTail = `${path.slice(rootEnd)}\\${resolvedTail}`;
resolvedAbsolute = isAbsolute;
}

if (resolvedDevice.length > 0 && resolvedAbsolute) {
break;
if (isAbsolute && resolvedDevice.length > 0) {
break;
}
}
}

Expand Down