Skip to content

crypto: always accept private keys as public keys #25217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tniessen wants to merge 4 commits into from
Closed

crypto: always accept private keys as public keys #25217

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bd5e127
crypto: always accept private keys as public keys
tniessen Dec 25, 2018
8f6040b
fixup! crypto: always accept private keys as public keys
tniessen Jan 3, 2019
6602a44
fixup! crypto: always accept private keys as public keys
tniessen Jan 3, 2019
63dabd5
fixup! fixup! crypto: always accept private keys as public keys
tniessen Jan 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! crypto: always accept private keys as public keys
  • Loading branch information
@tniessen
tniessen committed Jan 3, 2019
commit 8f6040b4f0d0bd764f22cb24ce916f0c785c646f
4 changes: 2 additions & 2 deletions doc/api/crypto.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1370,7 +1370,7 @@ This can be called many times with new data as it is streamed.
added: v0.1.92
changes:
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/???
pr-url: https://github.com/nodejs/node/pull/25217
description: The key can now be a private key instead of a public key.
Comment thread
tniessen marked this conversation as resolved.
Resolved
- version: v8.0.0
pr-url: https://github.com/nodejs/node/pull/11705
Expand Down Expand Up @@ -1828,7 +1828,7 @@ added: v11.6.0
added: REPLACEME
changes:
- version: REPLACEME
pr-url: TODO
pr-url: https://github.com/nodejs/node/pull/25217
description: The `key` argument can now be a private key.
-->
* `key` {Object | string | Buffer}
Expand Down