Skip to content

test: migrate process.binding to internalBinding for misc. #24952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BeniCheni wants to merge 12 commits into from
Closed

test: migrate process.binding to internalBinding for misc. #24952

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
cca74a4
lib: migrate process.binding to internalBinding for misc modules
BeniCheni Dec 11, 2018
6b348d3
src: revert incorrect internalBinding back to process.binding
BeniCheni Dec 15, 2018
bc891a7
test: update require os constants' signals child process spawnsync tests
BeniCheni Dec 17, 2018
1fa0d8f
test: revert to process.binding in test-process-binding.js
BeniCheni Dec 17, 2018
15c5aea
test: update require fs constants in test-process-constants-noatime.js
BeniCheni Dec 17, 2018
081db81
test: add semicolon in test-child-process-spawnsync-validation-errors.js
BeniCheni Dec 17, 2018
741e63d
Update test/parallel/test-fs-readdir-types.js
joyeecheung Dec 17, 2018
0f4db2d
test: update require os constants in test-dgram-bind-fd.js
joyeecheung Dec 17, 2018
63a7690
test: remove unused flag in child process spawnsync validation errors…
BeniCheni Feb 23, 2019
ae788ad
test: enable common.hasCrypto test for internal binding whitelist test
BeniCheni Feb 27, 2019
d9f1730
fixup
addaleax Mar 4, 2019
feddd9d
fixup
addaleax Mar 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
src: revert incorrect internalBinding back to process.binding 
Revert the previous incorrect migration of internalBinding from
process.binding in lib/stream & inspect_repl.

Refs: #22160
  • Loading branch information
@BeniCheni
BeniCheni committed Feb 27, 2019
commit 6b348d38b1a17893c2218659d17cf44e80d21e46
2 changes: 1 addition & 1 deletion deps/node-inspect/lib/internal/inspect_repl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ function extractFunctionName(description) {
return fnNameMatch ? `: ${fnNameMatch[1]}` : '';
}

const NATIVES = internalBinding('natives');
const NATIVES = process.binding('natives');
function isNativeUrl(url) {
return url.replace('.js', '') in NATIVES || url === 'bootstrap_node.js';
}
Expand Down
2 changes: 1 addition & 1 deletion lib/stream.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ try {
// Please do not convert process.binding() to internalBinding() here.
// This is for compatibility with older versions when loaded as
// readable-stream.
Stream._isUint8Array = internalBinding('util').isUint8Array;
Stream._isUint8Array = process.binding('util').isUint8Array;
}
} catch (e) { // eslint-disable-line no-unused-vars
}
Expand Down