Repository navigation
Conversation
Member
|
@nodejs/v8-inspector Should these changes land in our repo or should they be upstreamed to https://chromium.googlesource.com/deps/inspector_protocol/? (If the latter, should this live more properly in |
cclauss
force-pushed
the
Py3-for-tools-inspector_protocol
branch
from
December 7, 2018 07:40
daf9dc6 to
aeb4481
Compare
cclauss
changed the title
Contributor
Author
|
@bricss Instead of a 👍 could I please ask you to Review changes because that will give project maintainers more confidence that you has read through the actual changes and believe that those changes improve the state of the project? Anyone can review a GitHub pull request:
Thanks for taking the time to go through these step which should help maintainers. |
$ __make lint-py__
```
./tools/markupsafe/_compat.py:21:17: F821 undefined name 'unicode'
text_type = unicode
^
./tools/markupsafe/_compat.py:22:26: F821 undefined name 'unicode'
string_types = (str, unicode)
^
./tools/markupsafe/_compat.py:24:23: F821 undefined name 'long'
int_types = (int, long)
^
```
cclauss
changed the title
Trott
approved these changes
Dec 7, 2018
commented
Dec 7, 2018
Member
ofrobots
approved these changes
Dec 7, 2018
cjihrig
approved these changes
Dec 7, 2018
Member
|
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19370/ ✔️ |
commented
Dec 10, 2018
Member
|
Landed in 5652cb0 |
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes