Skip to content

test: increase coverage of internal/stream/end-of-stream #23751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lrdcasimir wants to merge 1 commit into from
Closed

test: increase coverage of internal/stream/end-of-stream #23751

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: increase coverage of internal/stream/end-of-stream 
This change adds test cases to call the function returned by
end-of-stream and asserts that callbacks are not called when
the stream is ended, or prematurely closed.
  • Loading branch information
@lrdcasimir
lrdcasimir committed Oct 19, 2018
commit 937345fc0c1b7f7394d5dcc6286abd5cf34d6cf7
22 changes: 22 additions & 0 deletions test/parallel/test-stream-finished.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,3 +153,25 @@ const { promisify } = require('util');
rs.push(null);
rs.resume();
}

// Test that calling returned function removes listeners
{
const ws = new Writable({
write(data, env, cb) {
cb();
}
});
const removeListener = finished(ws, common.mustNotCall());
removeListener();
ws.end();
}

{
const rs = new Readable();
const removeListeners = finished(rs, common.mustNotCall());
removeListeners();

rs.emit('close');
rs.push(null);
rs.resume();
}