Skip to content

n-api: make per-Context-ness of napi_env explicit #23689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 2 commits into from
Closed

n-api: make per-Context-ness of napi_env explicit #23689

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3fe948d
n-api: make per-`Context`-ness of `napi_env` explicit
addaleax Oct 16, 2018
2f3c078
fixup! n-api: make per-`Context`-ness of `napi_env` explicit
addaleax Oct 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! n-api: make per-Context-ness of napi_env explicit
  • Loading branch information
@addaleax
addaleax committed Oct 21, 2018
commit 2f3c0780b6af09c8eccf2b6794d20e990d93438e
2 changes: 1 addition & 1 deletion src/node_api.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ struct napi_env__ {
CHECK_NOT_NULL(node_env());
}

v8::Isolate* isolate; // Shortcut for context()->GetIsolate()
v8::Isolate* const isolate; // Shortcut for context()->GetIsolate()
node::Persistent<v8::Context> context_persistent;

inline v8::Local<v8::Context> context() const {
Expand Down